gz-math8: remove test based on manual compiler flags #2723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Addisu Z. Taddese <[email protected]>
9 tasks
Signed-off-by: Steve Peters <[email protected]>
scpeters
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in gazebosim/gz-math#614 (comment), the gz-math8 bottle install jobs are broken after gazebosim/gz-math#614. This is because the PR made changes to the
SignalStats.hhfile to include a header fromgz-utils. One solution is to update the manual flags to includegz-utils3, but that proved to be nontrivial because the variables defined by homebrew are specific to the package being built, in this case gz-math8. Figuring out the library and include directories forgz-utils3would involve using theHOMEBREW_PREFIXvariable and somehow determining the version ofgz-utils3. So, instead I opted to remove this test. @scpeters suggested implementing a replacement withpkg-config, but I think we should do that in follow up PR.